Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 216293008: Add a temporary CHECK to IPC::Channel::Send() to help track down crash. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a temporary CHECK to IPC::Channel::Send() to help track down crash. TBR=cbentzel@chromium.org, cpu@chromium.org BUG=357915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260373

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ipc/ipc_channel_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 8 months ago (2014-03-29 17:09:36 UTC) #1
viettrungluu
(Landing TBR to get in for a quick Canary build, at kareng's request.)
6 years, 8 months ago (2014-03-29 17:16:18 UTC) #2
viettrungluu
Committed patchset #1 manually as r260373 (tree was closed).
6 years, 8 months ago (2014-03-29 17:16:48 UTC) #3
viettrungluu
On 2014/03/29 17:16:48, viettrungluu wrote: > Committed patchset #1 manually as r260373 (tree was closed). ...
6 years, 8 months ago (2014-03-29 19:55:52 UTC) #4
no sievers
https://codereview.chromium.org/216293008/diff/1/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/216293008/diff/1/ipc/ipc_channel_win.cc#newcode84 ipc/ipc_channel_win.cc:84: CHECK(message) << "crbug.com/357915"; // TODO(vtl): Remove once bug resolved. ...
6 years, 8 months ago (2014-03-29 20:48:40 UTC) #5
cbentzel
6 years, 8 months ago (2014-03-29 21:13:35 UTC) #6
Message was sent while issue was closed.
LGTM as is but agree with sievers analysis after looking at the assembly he
posted.

Powered by Google App Engine
This is Rietveld 408576698