Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 216293007: ash::internal::TrayBluetooth: Hide spinner if discovery session stops. (Closed)

Created:
6 years, 9 months ago by armansito
Modified:
6 years, 8 months ago
Reviewers:
keybuk, Daniel Erat, jennyz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash::internal::TrayBluetooth: Hide spinner if discovery session stops. Changed TrayBluetooth to update the spinner not based on whether or not it requested discovery but whether or not system tray delegate has an active discovery session. The code will now automatically try to restart discovery if discovery stops unexpectedly and start or stop the throbber based on that. Also renamed UpdateBlueToothDeviceList to UpdateBluetoothDeviceList and UpdateBluetoothDeviceList to UpdateBluetoothDeviceListHelper. BUG=345494 TEST=1. Hack bluetoothd to allow stopping discovery via command-line regardless of the client who intiated it. Use bluetoothctl and run 'scan off' after running discovery via TrayBluetooth. The spinner should visibly update and discovery should restart (upon which the spinner should re-update). 2. Start discovery outside of TrayBluetooth (e.g chrome://settings). Opening the tray discovery dialog should work as expected (i.e. the spinner should animate and found devices list should be populated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M ash/system/bluetooth/tray_bluetooth.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
armansito
jennyz@: ash/system/* derat@: chrome/browser/ui/ash/* keybuk@: general Bluetooth.
6 years, 9 months ago (2014-03-29 00:40:52 UTC) #1
Daniel Erat
lgtm for chrome/browser/ui/ash
6 years, 9 months ago (2014-03-29 00:45:34 UTC) #2
keybuk
lgtm
6 years, 8 months ago (2014-03-31 16:09:37 UTC) #3
jennyz
lgtm
6 years, 8 months ago (2014-03-31 18:10:49 UTC) #4
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 8 months ago (2014-03-31 20:52:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/216293007/1
6 years, 8 months ago (2014-03-31 20:53:19 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 00:37:08 UTC) #7
Message was sent while issue was closed.
Change committed as 260718

Powered by Google App Engine
This is Rietveld 408576698