Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2162913002: Set request context when restoring cached CSSFontFaceSrcValue resource (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
Mike West
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, estark, nasko, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set request context when restoring cached CSSFontFaceSrcValue resource This patch changes the resource context type of the FetchRequest issued in CSSFontFaceSrcValue::restoreCachedResourceIfNeeded from WebURLRequest::RequestContextUnspecified to WebURLRequest::RequestContextFont. BUG=624474 Committed: https://crrev.com/1e098e3c78fca34a9f274286162272aaeb3ecad8 Cr-Commit-Position: refs/heads/master@{#406805}

Patch Set 1 #

Patch Set 2 : Add layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/css/font-face-src-cached.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/css/resources/font-face-src-cached-iframe.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/css/resources/font-face-via-https.css View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
petrcermak
Please take a look at this tiny patch. Thanks, Petr
4 years, 5 months ago (2016-07-19 13:04:44 UTC) #2
nednguyen
On 2016/07/19 13:04:44, petrcermak wrote: > Please take a look at this tiny patch. > ...
4 years, 5 months ago (2016-07-19 13:07:48 UTC) #3
petrcermak
On 2016/07/19 13:07:48, nednguyen wrote: > On 2016/07/19 13:04:44, petrcermak wrote: > > Please take ...
4 years, 5 months ago (2016-07-19 13:14:44 UTC) #4
petrcermak
Mike: I added a layout test as requested. PTAL. Thanks, Petr
4 years, 5 months ago (2016-07-20 18:18:11 UTC) #5
Mike West
LGTM, thanks!
4 years, 5 months ago (2016-07-21 07:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162913002/20001
4 years, 5 months ago (2016-07-21 09:06:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 09:10:19 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:12:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e098e3c78fca34a9f274286162272aaeb3ecad8
Cr-Commit-Position: refs/heads/master@{#406805}

Powered by Google App Engine
This is Rietveld 408576698