Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2162893002: Revert of Remove Enable Exits On Suspend flags on iOS (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Enable Exits On Suspend flags on iOS (patchset #1 id:1 of https://codereview.chromium.org/2151553002/ ) Reason for revert: Broke downstream tree as -[UIApplication cr_interpose_beginBackgroundTaskWithExpirationHandler:] is used. Original issue's description: > Remove Enable Exits On Suspend flags on iOS > > This CL removes the Enable Exits On Suspend flag on iOS. > > BUG=627859 > > Committed: https://crrev.com/c8ae1453cbc9ee793144a6da2c3a41e5db2aeae2 > Cr-Commit-Position: refs/heads/master@{#406234} TBR=rohitrao@chromium.org,lpromero@chromium.org,gambard@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627859 Committed: https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae Cr-Commit-Position: refs/heads/master@{#406257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -0 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/app/UIApplication+ExitsOnSuspend.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/app/UIApplication+ExitsOnSuspend.mm View 1 chunk +110 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Created Revert of Remove Enable Exits On Suspend flags on iOS
4 years, 5 months ago (2016-07-19 12:51:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162893002/1
4 years, 5 months ago (2016-07-19 12:51:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 12:52:15 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae Cr-Commit-Position: refs/heads/master@{#406257}
4 years, 5 months ago (2016-07-19 12:53:31 UTC) #6
gambard
4 years, 5 months ago (2016-07-20 08:23:41 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2159423002/ by gambard@chromium.org.

The reason for reverting is: Problem fixed..

Powered by Google App Engine
This is Rietveld 408576698