Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2162873003: Remove m_pList conditionals from CPWL_ListBox (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@bug_628995
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove m_pList conditionals from CPWL_ListBox We create |m_pList| in the constructor and it is never reset during the lifetime of the class or subclasses. Remove the conditional checks on the existence of |m_pList|. Committed: https://pdfium.googlesource.com/pdfium/+/3617751cea45fd636d58f535a662337fcea40c4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -195 lines) Patch
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 3 chunks +16 lines, -27 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 12 chunks +100 lines, -168 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-19 13:28:46 UTC) #2
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-19 17:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162873003/1
4 years, 5 months ago (2016-07-19 17:15:58 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 17:16:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3617751cea45fd636d58f535a662337fcea4...

Powered by Google App Engine
This is Rietveld 408576698