Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2162873002: [system health] Add flipboard to system health stories. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system health] Add flipboard to system health stories. Flipboard on mobile exercises interesting workload, where news items are rendered using canvas. BUG=589726 Committed: https://crrev.com/fd43bee2311ab250b3b6181ccd8be45092234eca Cr-Commit-Position: refs/heads/master@{#406550}

Patch Set 1 #

Patch Set 2 : add loading story and upload wpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M tools/perf/page_sets/data/system_health_desktop.json View 1 1 chunk +7 lines, -1 line 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_020.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_021.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_024.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_025.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 1 chunk +17 lines, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ulan
ptal
4 years, 5 months ago (2016-07-20 10:06:02 UTC) #3
petrcermak
LGTM. Please add "BUG=589726" to the description. Thanks, Petr
4 years, 5 months ago (2016-07-20 11:18:51 UTC) #4
nednguyen
lgtm
4 years, 5 months ago (2016-07-20 11:33:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162873002/20001
4 years, 5 months ago (2016-07-20 13:24:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 14:29:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 14:31:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd43bee2311ab250b3b6181ccd8be45092234eca
Cr-Commit-Position: refs/heads/master@{#406550}

Powered by Google App Engine
This is Rietveld 408576698