Add StringView constructor that takes a ref to save a branch in CSSTokenizerInputStream::rangeAt

Add StringView constructor that takes a ref to save a branch in CSSTokenizerInputStream::rangeAt.

CSSTokenizerInputStream never has a null m_string so the null check in StringView's
constructor is just waste. It also makes the code bigger if we were to inline the
function since we need both the null (clear()) and the non-null (set()) code from
StringView.

Lets introduce a StringView constructor set that takes a StringImpl& and then
use it in CSSTokenizerInputStream::rangeAt() allowing us to skip the branch.
I then also made the function inline.

BUG=615174, 605792
Committed: https://crrev.com/9d4b30269e660985f657126b21e7ace229ec2e07
Cr-Commit-Position: refs/heads/master@{#406375}

[esprehn, 2016-07-19 06:57:54]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 06:58:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 07:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 07:07:14]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2016-07-19 07:09:58]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 07:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-19 08:35:36]

Description was changed from

==========
CSSTokenizerInputStream::rangeAt.

BUG=615174,605792
==========

to

==========
Add StringView constructor that takes a ref to save a branch in
CSSTokenizerInputStream::rangeAt.

CSSTokenizerInputStream never has a null m_string so the null check in
StringView's
constructor is just waste. It also makes the code bigger if we were to inline
the
function since we need both the null (clear()) and the non-null (set()) code
from
StringView.

Lets introduce a StringView constructor set that takes a StringImpl& and then
use it in CSSTokenizerInputStream::rangeAt() allowing us to skip the branch.
I then also made the function inline.

BUG=615174,605792
==========

[esprehn, 2016-07-19 08:40:20]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, timloh@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:27:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:27:57]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-07-19 19:56:05]

LGTM

[esprehn, 2016-07-19 20:40:09]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:48:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-19 20:48:36]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 20:50:29]

Description was changed from

==========
Add StringView constructor that takes a ref to save a branch in
CSSTokenizerInputStream::rangeAt.

CSSTokenizerInputStream never has a null m_string so the null check in
StringView's
constructor is just waste. It also makes the code bigger if we were to inline
the
function since we need both the null (clear()) and the non-null (set()) code
from
StringView.

Lets introduce a StringView constructor set that takes a StringImpl& and then
use it in CSSTokenizerInputStream::rangeAt() allowing us to skip the branch.
I then also made the function inline.

BUG=615174,605792
==========

to

==========
Add StringView constructor that takes a ref to save a branch in
CSSTokenizerInputStream::rangeAt.

CSSTokenizerInputStream never has a null m_string so the null check in
StringView's
constructor is just waste. It also makes the code bigger if we were to inline
the
function since we need both the null (clear()) and the non-null (set()) code
from
StringView.

Lets introduce a StringView constructor set that takes a StringImpl& and then
use it in CSSTokenizerInputStream::rangeAt() allowing us to skip the branch.
I then also made the function inline.

BUG=615174,605792

Committed: https://crrev.com/9d4b30269e660985f657126b21e7ace229ec2e07
Cr-Commit-Position: refs/heads/master@{#406375}
==========

[commit-bot: I haz the power, 2016-07-19 20:50:31]

Patchset 2 (id:??) landed as
https://crrev.com/9d4b30269e660985f657126b21e7ace229ec2e07
Cr-Commit-Position: refs/heads/master@{#406375}