Issue 2162853004: bluetooth: Only unregister the receiver if dialog hasn't been closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2162853004: bluetooth: Only unregister the receiver if dialog hasn't been closed. (Closed)

Created:
4 years, 5 months ago by ortuno

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

bluetooth: Only unregister the receiver if dialog hasn't been closed. Also modifies nativeOnDialogFinished to more closely resemble the non-test nativeOnDialogFinished function. This change would have allowed us to catch the problem with the receiver. BUG=625398 Review-Url: https://codereview.chromium.org/2129763002 Cr-Commit-Position: refs/heads/master@{#404170} (cherry picked from commit d04c4837088288ebe2d6348e29018f754a1f91d7) Committed: https://chromium.googlesource.com/chromium/src/+/55f24de21bf238a0bf5715e8d23c1d1e095cb9ea

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

ortuno

4 years, 5 months ago (2016-07-19 21:30:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
55f24de21bf238a0bf5715e8d23c1d1e095cb9ea.