Simplify and correct logic in CallSite::GetMethodName

Simplify and correct logic in CallSite::GetMethodName

SharedFunctionInfo::name is always a String if present (never a Symbol),
so there's no need to first test it for IsName() before testing IsString().
This is enforced by a check in %FunctionSetName.

As a bonus, the code no longer looks invalid (unconditionally casting
a Name to a String). The logic came into this broken-looking state
accidentally in the flag cleanup CL https://codereview.chromium.org/2096933002/.

Committed: https://crrev.com/f1cf71aa4daf3f8975b528fd9c554b17dd26cf14
Cr-Commit-Position: refs/heads/master@{#37914}

[adamk, 2016-07-19 19:53:40]

adamk@chromium.org changed reviewers:
+ yangguo@chromium.org

[adamk, 2016-07-19 19:54:19]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 19:54:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:26:08]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-20 06:19:34]

On 2016/07/19 19:53:40, adamk wrote:

lgtm.

[adamk, 2016-07-20 18:09:32]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:09:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 18:12:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 18:13:57]

Description was changed from

==========
Simplify and correct logic in CallSite::GetMethodName

SharedFunctionInfo::name is always a String if present (never a Symbol),
so there's no need to first test it for IsName() before testing IsString().
This is enforced by a check in %FunctionSetName.

As a bonus, the code no longer looks invalid (unconditionally casting
a Name to a String). The logic came into this broken-looking state
accidentally in the flag cleanup CL https://codereview.chromium.org/2096933002/.
==========

to

==========
Simplify and correct logic in CallSite::GetMethodName

SharedFunctionInfo::name is always a String if present (never a Symbol),
so there's no need to first test it for IsName() before testing IsString().
This is enforced by a check in %FunctionSetName.

As a bonus, the code no longer looks invalid (unconditionally casting
a Name to a String). The logic came into this broken-looking state
accidentally in the flag cleanup CL https://codereview.chromium.org/2096933002/.

Committed: https://crrev.com/f1cf71aa4daf3f8975b528fd9c554b17dd26cf14
Cr-Commit-Position: refs/heads/master@{#37914}
==========

[commit-bot: I haz the power, 2016-07-20 18:13:58]

Patchset 1 (id:??) landed as
https://crrev.com/f1cf71aa4daf3f8975b528fd9c554b17dd26cf14
Cr-Commit-Position: refs/heads/master@{#37914}