Issue 216283003: Use the StyleResolverParentScope for ShadowRoot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216283003: Use the StyleResolverParentScope for ShadowRoot (Closed)

Created:
6 years, 9 months ago by esprehn

Modified:
6 years, 9 months ago

Reviewers:
eseidel, tasak, ojan

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use the StyleResolverParentScope for ShadowRoot In r170168 I made pushing the parent scopes lazy for Elements, but I didn't make it lazy for ShadowRoot. This meant that you could trigger a style recalc on a single element in a ShadowRoot and then we'd push the scopes out of order, where we'd push all the ShadowRoots on the way down and then push all the elements at the end. I wasn't able to show any rendering errors, but by inspection it's wrong and it appears it was making us go through the ScopedStyleTree::resolveStyleCache code path more often than needed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170312

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -13 lines)			Patch
	M	Source/core/css/resolver/StyleResolverParentScope.h	View		3 chunks	+17 lines, -6 lines	0 comments	Download
	M	Source/core/dom/shadow/ShadowRoot.cpp	View		4 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/216283003/1

6 years, 9 months ago (2014-03-28 10:01:24 UTC) #5

Message was sent while issue was closed.

Change committed as 170312

Expand Messages | Collapse Messages