Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2162813002: Revert "Add a GN assert preventing android templates in non-default toolchain" (Closed)

Created:
4 years, 5 months ago by michaelbai
Modified:
4 years, 5 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add a GN assert preventing android templates in non-default toolchain" This reverts commit 09d787e26cac78497700f700c31361099bf9071a. BUG=629371 Committed: https://crrev.com/492ef1276bde542b494a57681d3ce0ea3a73ea80 Cr-Commit-Position: refs/heads/master@{#406210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/config/android/config.gni View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
michaelbai
4 years, 5 months ago (2016-07-19 01:38:52 UTC) #3
agrieve
On 2016/07/19 01:38:52, michaelbai wrote: lgtm
4 years, 5 months ago (2016-07-19 01:41:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162813002/1
4 years, 5 months ago (2016-07-19 04:06:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 04:10:47 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 04:10:55 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 04:12:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/492ef1276bde542b494a57681d3ce0ea3a73ea80
Cr-Commit-Position: refs/heads/master@{#406210}

Powered by Google App Engine
This is Rietveld 408576698