Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6361)

Unified Diff: chrome/browser/metrics/metrics_memory_details.cc

Issue 2162783002: Add Memory.{Browser,Renderer}.Large2 metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_memory_details_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_memory_details.cc
diff --git a/chrome/browser/metrics/metrics_memory_details.cc b/chrome/browser/metrics/metrics_memory_details.cc
index 8da941d07a2e3f2e2072205fa7a28004e4d98dfc..be35170b9c0706aed584407d57df7b9ff5b541ad 100644
--- a/chrome/browser/metrics/metrics_memory_details.cc
+++ b/chrome/browser/metrics/metrics_memory_details.cc
@@ -89,8 +89,7 @@ void MetricsMemoryDetails::UpdateHistograms() {
aggregate_memory += sample;
switch (browser.processes[index].process_type) {
case content::PROCESS_TYPE_BROWSER:
- UMA_HISTOGRAM_MEMORY_KB("Memory.Browser", sample);
- UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Browser.Large", sample);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Browser.Large2", sample / 1024);
continue;
case content::PROCESS_TYPE_RENDERER: {
ProcessMemoryInformation::RendererProcessType renderer_type =
@@ -110,7 +109,8 @@ void MetricsMemoryDetails::UpdateHistograms() {
case ProcessMemoryInformation::RENDERER_NORMAL:
default:
// TODO(erikkay): Should we bother splitting out the other subtypes?
- UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer", sample);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Renderer.Large2",
+ sample / 1024);
int diff;
if (memory_growth_tracker_ &&
memory_growth_tracker_->UpdateSample(
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_memory_details_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698