Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2162763003: [parser] Add default constructor for PreParserExpression (Closed)

Created:
4 years, 5 months ago by nickie
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Add default constructor for PreParserExpression In a few places in the parser base, we were forced to initialize variables of type ExpressionT even if it's not necessary, as they are assigned to later on before their use. This was required because, for the case of the preparser, ExpressionT is PreParserExpression which had no default constructor. This patch adds a default constructor, equivalent to EmptyExpression for this class, and gets rid of the unnecessary initializations. R=adamk@chromium.org, littledan@chromium.org BUG= LOG=N Committed: https://crrev.com/6ce36869bca9a60acc77c447f7e340c3f9d1f8f2 Cr-Commit-Position: refs/heads/master@{#37884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/parsing/parser-base.h View 9 chunks +8 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
nickie
4 years, 5 months ago (2016-07-19 09:34:27 UTC) #1
adamk
lgtm
4 years, 5 months ago (2016-07-19 18:56:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162763003/1
4 years, 5 months ago (2016-07-20 07:32:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 07:34:53 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 07:35:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ce36869bca9a60acc77c447f7e340c3f9d1f8f2
Cr-Commit-Position: refs/heads/master@{#37884}

Powered by Google App Engine
This is Rietveld 408576698