Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2162753002: Storage manager: Show accounts panel from "Other users" link. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Show accounts panel from "Other users" link. BUG=625070 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fd79db4b1cea32d3fc151fb753e767a2c24b765f Cr-Commit-Position: refs/heads/master@{#406222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
fukino
Could you take a look? Thanks!
4 years, 5 months ago (2016-07-18 23:55:15 UTC) #3
Dan Beam
lgtm
4 years, 5 months ago (2016-07-19 01:52:07 UTC) #4
fukino
Thank you!
4 years, 5 months ago (2016-07-19 04:59:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162753002/1
4 years, 5 months ago (2016-07-19 04:59:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 06:21:16 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 06:21:26 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 06:22:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd79db4b1cea32d3fc151fb753e767a2c24b765f
Cr-Commit-Position: refs/heads/master@{#406222}

Powered by Google App Engine
This is Rietveld 408576698