Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2162733002: Converted Observatory nav-menu element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Better Tests #

Total comments: 2

Patch Set 3 : Merged with master #

Patch Set 4 : Converted from single to triple quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -55 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/menu.dart View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/menu_wrapper.dart View 1 chunk +61 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +0 lines, -47 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/nav/menu/element_test.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/menu/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-18 22:45:54 UTC) #2
cbernaschina
4 years, 5 months ago (2016-07-18 23:15:45 UTC) #3
Cutch
lgtm https://codereview.chromium.org/2162733002/diff/20001/runtime/observatory/lib/src/elements/nav/menu.dart File runtime/observatory/lib/src/elements/nav/menu.dart (right): https://codereview.chromium.org/2162733002/diff/20001/runtime/observatory/lib/src/elements/nav/menu.dart#newcode13 runtime/observatory/lib/src/elements/nav/menu.dart:13: style.text = 'li.nav-menu_label, li.nav-menu_spacer {' use the ''' ...
4 years, 5 months ago (2016-07-19 14:19:05 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-19 18:29:50 UTC) #5
cbernaschina
https://codereview.chromium.org/2162733002/diff/20001/runtime/observatory/lib/src/elements/nav/menu.dart File runtime/observatory/lib/src/elements/nav/menu.dart (right): https://codereview.chromium.org/2162733002/diff/20001/runtime/observatory/lib/src/elements/nav/menu.dart#newcode13 runtime/observatory/lib/src/elements/nav/menu.dart:13: style.text = 'li.nav-menu_label, li.nav-menu_spacer {' On 2016/07/19 14:19:05, Cutch ...
4 years, 5 months ago (2016-07-19 19:18:20 UTC) #6
rmacnak
lgtm
4 years, 5 months ago (2016-07-19 22:22:50 UTC) #7
cbernaschina
4 years, 5 months ago (2016-07-19 22:28:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b7ffd9339ce01383c440be2b43973a273721d842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698