Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 216273002: Avoid calling Isolate::GetCurrent() in V8PerContextData (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Avoid calling Isolate::GetCurrent() in V8PerContextData BUG=357087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/v8/V8PerContextData.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-28 04:32:16 UTC) #1
abarth-chromium
LGTM!
6 years, 9 months ago (2014-03-28 04:54:52 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-28 04:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/216273002/1
6 years, 9 months ago (2014-03-28 04:55:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 05:01:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-28 05:01:46 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-28 05:04:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/216273002/1
6 years, 9 months ago (2014-03-28 05:05:04 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 05:58:32 UTC) #9
Message was sent while issue was closed.
Change committed as 170275

Powered by Google App Engine
This is Rietveld 408576698