Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2162653002: Switch input_devices mojom to use_new_wrapper_types. (Closed)

Created:
4 years, 5 months ago by kylechar
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch input_devices mojom to use_new_wrapper_types. Remove GN arg to use mojo::Array<> instead of std::vector<> for input device related interfaces. Update interface implementation accordingly. BUG=none Committed: https://crrev.com/1c90576dae2d9204ec474565fae977513335a067 Cr-Commit-Position: refs/heads/master@{#406397}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M services/ui/public/cpp/input_devices/input_device_client.h View 1 chunk +8 lines, -8 lines 0 comments Download
M services/ui/public/cpp/input_devices/input_device_client.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M services/ui/public/interfaces/input_devices/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kylechar
4 years, 5 months ago (2016-07-18 20:34:04 UTC) #3
Ben Goodger (Google)
lgtm https://codereview.chromium.org/2162653002/diff/1/services/ui/public/interfaces/input_devices/BUILD.gn File services/ui/public/interfaces/input_devices/BUILD.gn (right): https://codereview.chromium.org/2162653002/diff/1/services/ui/public/interfaces/input_devices/BUILD.gn#newcode16 services/ui/public/interfaces/input_devices/BUILD.gn:16: use_new_wrapper_types = true You can just remove this ...
4 years, 5 months ago (2016-07-19 19:47:50 UTC) #4
kylechar
Thanks! https://codereview.chromium.org/2162653002/diff/1/services/ui/public/interfaces/input_devices/BUILD.gn File services/ui/public/interfaces/input_devices/BUILD.gn (right): https://codereview.chromium.org/2162653002/diff/1/services/ui/public/interfaces/input_devices/BUILD.gn#newcode16 services/ui/public/interfaces/input_devices/BUILD.gn:16: use_new_wrapper_types = true On 2016/07/19 19:47:50, Ben Goodger ...
4 years, 5 months ago (2016-07-19 19:50:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162653002/20001
4 years, 5 months ago (2016-07-19 19:53:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/262632)
4 years, 5 months ago (2016-07-19 20:19:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162653002/20001
4 years, 5 months ago (2016-07-19 21:28:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 22:27:06 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:29:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c90576dae2d9204ec474565fae977513335a067
Cr-Commit-Position: refs/heads/master@{#406397}

Powered by Google App Engine
This is Rietveld 408576698