Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162643002: Revert "Reapply zone tasks." (Closed)

Created:
4 years, 5 months ago by Alan Knight
Modified:
4 years, 5 months ago
Reviewers:
terry, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reapply zone tasks." This reverts commit 6a7c037aa62b68215d0e8bdaf16e5477383f4687. BUG= Committed: https://github.com/dart-lang/sdk/commit/30b489578d9ee587d2ca622346e2051a869fb994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -3905 lines) Patch
M sdk/lib/async/timer.dart View 3 chunks +8 lines, -139 lines 0 comments Download
M sdk/lib/async/zone.dart View 32 chunks +64 lines, -353 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 21 chunks +50 lines, -431 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +49 lines, -400 lines 0 comments Download
D tests/html/event_subscription_specification_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/html/event_zone_task_test.dart View 1 chunk +0 lines, -239 lines 0 comments Download
M tests/html/html.status View 4 chunks +1 line, -5 lines 0 comments Download
D tests/html/request_animation_task_test.dart View 1 chunk +0 lines, -170 lines 0 comments Download
D tests/html/xhr_task2_test.dart View 1 chunk +0 lines, -280 lines 0 comments Download
D tests/html/xhr_task_test.dart View 1 chunk +0 lines, -508 lines 0 comments Download
D tests/lib/async/zone_task_test.dart View 1 chunk +0 lines, -310 lines 0 comments Download
D tests/lib/async/zone_timer_task_test.dart View 1 chunk +0 lines, -515 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/docs/docs.json View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 9 chunks +16 lines, -99 lines 0 comments Download
M tools/dom/src/shared_html.dart View 1 chunk +19 lines, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 4 chunks +5 lines, -125 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 6 chunks +8 lines, -190 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Alan Knight
TBR
4 years, 5 months ago (2016-07-18 20:12:26 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as 30b489578d9ee587d2ca622346e2051a869fb994 (presubmit successful).
4 years, 5 months ago (2016-07-18 20:12:43 UTC) #4
terry
lgtm
4 years, 5 months ago (2016-07-18 20:25:36 UTC) #5
Bill Hesse
You also need to revert the follow-up CL https://github.com/dart-lang/sdk/commit/3daaf384 I'll make a CL to do ...
4 years, 5 months ago (2016-07-19 09:50:20 UTC) #7
Bill Hesse
4 years, 5 months ago (2016-07-19 13:00:55 UTC) #8
Message was sent while issue was closed. 
On 2016/07/19 09:50:20, Bill Hesse wrote:
> You also need to revert the follow-up CL
> https://github.com/dart-lang/sdk/commit/3daaf384
> 
> I'll make a CL to do this.

Follow-up commit is 
https://codereview.chromium.org/2159183003/
landed as
bde8d3efc6f7558edda6a1cad879ff4a264ddabe
and also in 1.18.0-dev.4.3, along with this commit.

Powered by Google App Engine
This is Rietveld 408576698