Revert "Remove all safesync_url functionality from gclient"

recipe_modules/gclient/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import types
 
 from recipe_engine.config import config_item_context, ConfigGroup, BadConf
 from recipe_engine.config import ConfigList, Dict, Single, Static, Set, List
 
 from . import api as gclient_api
 
 
 def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None,
                PATCH_PROJECT=None, BUILDSPEC_VERSION=None,
                **_kwargs):
   deps = '.DEPS.git' if GIT_MODE else 'DEPS'
   cache_dir = str(CACHE_DIR) if CACHE_DIR else None
   return ConfigGroup(
     solutions = ConfigList(
       lambda: ConfigGroup(
         name = Single(basestring),
         url = Single(basestring),
         deps_file = Single(basestring, empty_val=deps, required=False,
                            hidden=False),
         managed = Single(bool, empty_val=True, required=False, hidden=False),
         custom_deps = Dict(value_type=(basestring, types.NoneType)),
         custom_vars = Dict(value_type=basestring),
+        safesync_url = Single(basestring, required=False),
 
         revision = Single(
             (basestring, gclient_api.RevisionResolver),
             required=False, hidden=True),
       )
     ),
     deps_os = Dict(value_type=basestring),
     hooks = List(basestring),
     target_os = Set(basestring),
     target_os_only = Single(bool, empty_val=False, required=False),
@@ skipping 140 matching lines @@
 def chromium_empty(c):
   c.solutions[0].deps_file = ''  # pragma: no cover
 
 @config_ctx(includes=['chromium_bare'])
 def chromium(c):
   s = c.solutions[0]
   s.custom_deps = mirror_only(c, {})
 
 @config_ctx(includes=['chromium'])
 def chromium_lkcr(c):
+  # TODO(phajdan.jr): Add git hashes for LKCR crbug.com/349277.
+  if c.GIT_MODE:
+    raise BadConf('Git has problems with safesync_url and LKCR, '
+                  'crbug.com/349277 crbug.com/109191')  # pragma: no cover
   s = c.solutions[0]
+  s.safesync_url = 'https://build.chromium.org/p/chromium/lkcr-status/lkgr'
+  # TODO(hinoka): Once lkcr exists and is a tag, it should just be lkcr
+  #               rather than origin/lkcr.
   s.revision = 'origin/lkcr'
 
 @config_ctx(includes=['chromium'])
 def chromium_lkgr(c):
   s = c.solutions[0]
+  safesync_url = 'https://chromium-status.appspot.com/lkgr'
+  if c.GIT_MODE:  # pragma: no cover
+    safesync_url = 'https://chromium-status.appspot.com/git-lkgr'
+    raise BadConf('Git has problems with safesync_url, crbug.com/109191.')
+  s.safesync_url = safesync_url
   s.revision = 'origin/lkgr'
 
 @config_ctx(includes=['chromium_bare'])
 def android_bare(c):
   # We inherit from chromium_bare to get the got_revision mapping.
   # NOTE: We don't set a specific got_revision mapping for src/repo.
   del c.solutions[0]
   c.got_revision_mapping['src'] = 'got_src_revision'
   s = c.solutions.add()
   s.deps_file = '.DEPS.git'
@@ skipping 458 matching lines @@
   soln = c.solutions.add()
   soln.name = 'gerrit-test-cq-normal'
   soln.url = 'https://chromium.googlesource.com/playground/gerrit-cq/normal.git'
 
 # TODO(phajdan.jr): Move to proper repo and add coverage.
 @config_ctx()
 def valgrind(c):  # pragma: no cover
   """Add Valgrind binaries to the gclient solution."""
   c.solutions[0].custom_deps['src/third_party/valgrind'] = \
     ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries')