Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162583004: Revert "Remove all safesync_url functionality from gclient" (Closed)

Created:
4 years, 5 months ago by smut
Modified:
4 years, 5 months ago
Reviewers:
agable, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove all safesync_url functionality from gclient" This reverts commit 99a7f805785be9e44f01886fa95ecc162edf2774. This reverts commit 2697cd19a7853609a4f06537306c9e5b8d34c65d. This reverts commit 8c51b6f1487c79647ea9d3299f776ea4e211fafe. This reverts commit d4aedc811b6d4c9a077fa9166de23974d5d4ba06. Reason for revert: Breaks iOS release branch builds. BUG=623762 TBR=agable,maruel Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ae7ea3167e96a546cb93949967d3d2ac0be89262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -76 lines) Patch
M fetch_configs/breakpad.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/chromium.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/dart.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/dartino.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/dartium.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/gyp.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/ios_internal.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/mojo.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/nacl.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/naclports.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/v8.py View 1 chunk +1 line, -0 lines 0 comments Download
M fetch_configs/webrtc.py View 1 chunk +1 line, -0 lines 0 comments Download
M gclient.py View 19 chunks +78 lines, -40 lines 0 comments Download
M gclient_scm.py View 4 chunks +88 lines, -3 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 1 chunk +6 lines, -0 lines 0 comments Download
M recipe_modules/gclient/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M recipe_modules/gclient/config.py View 2 chunks +13 lines, -0 lines 0 comments Download
M recipe_modules/gclient/example.py View 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_modules/gclient/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/example.expected/revision.json View 2 chunks +1 line, -3 lines 0 comments Download
M recipe_modules/gclient/example.expected/tryserver.json View 2 chunks +1 line, -3 lines 0 comments Download
M tests/gclient_scm_test.py View 1 chunk +100 lines, -0 lines 0 comments Download
M tests/gclient_smoketest.py View 6 chunks +85 lines, -19 lines 0 comments Download
M tests/gclient_test.py View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
smut
This has been broken for too long, people are getting mad.
4 years, 5 months ago (2016-07-18 18:52:38 UTC) #3
smut
Committed patchset #1 (id:1) manually as ae7ea3167e96a546cb93949967d3d2ac0be89262.
4 years, 5 months ago (2016-07-18 18:59:49 UTC) #5
friedman
4 years, 5 months ago (2016-07-19 21:40:03 UTC) #6
Message was sent while issue was closed. 
On 2016/07/18 18:59:49, smut wrote:
> Committed patchset #1 (id:1) manually as
> ae7ea3167e96a546cb93949967d3d2ac0be89262.

Please CC or alert chrome-labs when changing managed flags on gclient.py

Powered by Google App Engine
This is Rietveld 408576698