Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2162573002: Add rtc_include_tests to override; WebRTC will require that shortly. (Closed)

Created:
4 years, 5 months ago by phoglund_chromium
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add rtc_include_tests to override; WebRTC will require that shortly. My current plan of attack is to flip rtc_include_tests over to true by default and make Chrome explicitly set it to false. This means I must land this change first and then the WebRTC change. This won't make parity with the WebRTC .gyp files worse since they handle this particular thing different anyway (.gyp files look at build_with_chromium to make this decision, I believe). BUG=webrtc:6119 Committed: https://crrev.com/586733f102a9656ea0302816bcbe375f43165681 Cr-Commit-Position: refs/heads/master@{#406329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build_overrides/webrtc.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
phoglund_chromium
4 years, 5 months ago (2016-07-18 15:10:04 UTC) #2
brettw
See my comment on the bug.
4 years, 5 months ago (2016-07-18 17:54:09 UTC) #3
phoglund_chromium
Changed title to reflect discussion in bug; PTAL
4 years, 5 months ago (2016-07-19 10:59:49 UTC) #5
brettw
lgtm
4 years, 5 months ago (2016-07-19 17:42:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162573002/1
4 years, 5 months ago (2016-07-19 18:28:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 18:38:19 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:39:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/586733f102a9656ea0302816bcbe375f43165681
Cr-Commit-Position: refs/heads/master@{#406329}

Powered by Google App Engine
This is Rietveld 408576698