Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2162553003: Re-land https://codereview.chromium.org/2103053002/ (Closed)

Created:
4 years, 5 months ago by dsansome
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@reland-5
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Re-land https://codereview.chromium.org/2103053002/ Cherry-pick buildbot 95deef27d7c531ead19e0ac86a9aa1546d4ee7f9: Re-run queries after certain OperationalErrors Sometimes malformed SQL can generate an OperationalError, so this looks at the message itself. It's unclear how this will work with localization. The code uses an exponential backoff algorithm (with a relatively small multiplier), and will retry for a day, which seems a reasonable get-the-db-server-fixed time. Fixes #2005. Hoepfully for good! BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/17ba0a73166bf637528205686ac74f8466eadfc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -51 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 2 chunks +74 lines, -50 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/test/unit/test_db_pool.py View 2 chunks +46 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsansome
4 years, 5 months ago (2016-07-19 01:07:50 UTC) #2
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-20 01:59:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162553003/1
4 years, 5 months ago (2016-07-20 04:15:59 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 04:20:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/17ba0a73166bf6375282...

Powered by Google App Engine
This is Rietveld 408576698