Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162503003: Cleanup fgas/crt. (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup fgas/crt. This CL removes unused methods and default parameters from the fgas/crt code. Committed: https://pdfium.googlesource.com/pdfium/+/34965459f4f53a77f6c925292304eface57d12c6

Patch Set 1 #

Patch Set 2 : Win fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -318 lines) Patch
M xfa/fde/cfde_txtedtpage.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fde/css/fde_css.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fde/css/fde_csscache.h View 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fde/css/fde_csscache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 4 chunks +11 lines, -11 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 6 chunks +9 lines, -7 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/fde/fde_iterator.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_codepage.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fgas/crt/fgas_codepage.cpp View 3 chunks +0 lines, -40 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 4 chunks +7 lines, -12 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 10 chunks +14 lines, -40 lines 0 comments Download
M xfa/fgas/crt/fgas_system.h View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fgas/crt/fgas_utils.h View 18 chunks +51 lines, -162 lines 0 comments Download
M xfa/fgas/crt/fgas_utils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_xml_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-18 15:14:28 UTC) #4
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-18 19:40:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162503003/20001
4 years, 5 months ago (2016-07-18 20:14:26 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:14:53 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/34965459f4f53a77f6c925292304eface57d...

Powered by Google App Engine
This is Rietveld 408576698