StyleBuilder should not know about StyleResolver.

Source/core/css/resolver/StyleResolverState.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 24 matching lines @@
 #include "core/rendering/style/StyleInheritedData.h"
 
 namespace WebCore {
 
 class FontDescription;
 class RenderRegion;
 
 class StyleResolverState {
 WTF_MAKE_NONCOPYABLE(StyleResolverState);
 public:
-    StyleResolverState(const Document*, Element*, RenderStyle* parentStyle = 0, RenderRegion* regionForStyling = 0);
+    StyleResolverState(Document*, Element*, RenderStyle* parentStyle = 0, RenderRegion* regionForStyling = 0);
     ~StyleResolverState();
 
+    // In FontLoader and CanvasRenderingContext2D, we don't have an element to grab the document from.
+    // This is why we have to store the document separately.
+    Document* document() const { return m_document; }

[dglazkov, 2013/08/01 22:19:41]

This is where things got a bit funky. StyleResolverState and
ElementResolveContext work well with each other in 99.999% cases. In 2 cases,
they disagree on what the value of document is. I had to bring back a
StyleResolverState::m_document to compensate for it.

[eseidel, 2013/08/01 22:53:48]

Seems like we should have a bug filed, or some sort of path forward here.

     // These are all just pass-through methods to ElementResolveContext.
-    Document* document() const { return m_elementContext.document(); }
     Element* element() const { return m_elementContext.element(); }
     const ContainerNode* parentNode() const { return m_elementContext.parentNode(); }
     const RenderStyle* rootElementStyle() const { return m_elementContext.rootElementStyle(); }
     EInsideLink elementLinkState() const { return m_elementContext.elementLinkState(); }
     bool distributedToInsertionPoint() const { return m_elementContext.distributedToInsertionPoint(); }
 
     const ElementResolveContext& elementContext() const { return m_elementContext; }
 
     void setStyle(PassRefPtr<RenderStyle> style) { m_style = style; }
     const RenderStyle* style() const { return m_style.get(); }
@@ skipping 57 matching lines @@
     // width/height/border/padding/... from the RenderStyle -> for SVG these values would never scale,
     // if we'd pass a 1.0 zoom factor everyhwere. So we only pass a zoom factor of 1.0 for specific
     // properties that are NOT allowed to scale within a zoomed SVG document (letter/word-spacing/font-size).
     bool useSVGZoomRules() const { return element() && element()->isSVGElement(); }
 
 private:
     friend class StyleResolveScope;
 
     void initElement(Element*);
 
+    Document* m_document;
     ElementResolveContext m_elementContext;
 
     // m_style is the primary output for each element's style resolve.
     RefPtr<RenderStyle> m_style;
 
     // m_parentStyle is not always just element->parentNode()->style()
     // so we keep it separate from m_elementContext.
     RefPtr<RenderStyle> m_parentStyle;
 
     // Required to ASSERT in applyProperties.
@@ skipping 13 matching lines @@
     ElementStyleResources m_elementStyleResources;
     // CSSToStyleMap is a pure-logic class and only contains
     // a back-pointer to this object.
     CSSToStyleMap m_styleMap;
     Vector<AtomicString> m_contentAttrValues;
 };
 
 } // namespace WebCore
 
 #endif // StyleResolverState_h