Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2162483003: Contenteditable w/ "-webkit-user-select:all" should be editable. (Closed)

Created:
4 years, 5 months ago by yoichio
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Contenteditable w/ "-webkit-user-select:all" should be editable. <div id ="div" style="-webkit-user-select:all" contenteditable="true"></div> should be editable. In this CL, we ignore "-webkit-user-select:all" if element has |contenteditable="true| in Node::hasEditableStyle and expandSelection by user click. BUG=618920 TEST=editing/selection/user-select/user-select-all-contenteditable.html, mouse/click- user-select-all-textarea.html, user-select/user-select-all-contenteditable.html Review-Url: https://codereview.chromium.org/2120913002 Cr-Commit-Position: refs/heads/master@{#405440} (cherry picked from commit d607a605c05ae726b55aa3a28b32c94a2ab597ff) Committed: https://chromium.googlesource.com/chromium/src/+/504692a84da84f81aa9ad585d23f41c73990d8de

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
yoichio
4 years, 5 months ago (2016-07-19 06:17:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
504692a84da84f81aa9ad585d23f41c73990d8de.

Powered by Google App Engine
This is Rietveld 408576698