Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 2162463002: Fix build failure for the broken merge on M52/M53 tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
index a82d04a16ae1598ae3ecf8a7bc424517bedae83c..fb21541d01ce1ac3bea1cecbc9b4066d0d1d2988 100644
--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
@@ -272,7 +272,7 @@ class CreateWindowTest : public testing::Test {
protected:
void SetUp() override
{
- m_webView = toWebViewImpl(WebView::create(&m_webViewClient, WebPageVisibilityStateVisible));
+ m_webView = toWebViewImpl(WebView::create(&m_webViewClient));
m_mainFrame = WebLocalFrame::create(WebTreeScopeType::Document, &m_webFrameClient);
m_webView->setMainFrame(m_mainFrame);
m_chromeClientImpl = toChromeClientImpl(&m_webView->page()->chromeClient());
@@ -297,7 +297,7 @@ TEST_F(CreateWindowTest, CreateWindowFromDeferredPage)
LocalFrame* frame = toWebLocalFrameImpl(m_mainFrame)->frame();
FrameLoadRequest request(frame->document());
WindowFeatures features;
- EXPECT_EQ(nullptr, m_chromeClientImpl->createWindow(frame, request, features, NavigationPolicyNewForegroundTab));
+ EXPECT_EQ(nullptr, m_chromeClientImpl->createWindow(frame, request, features, NavigationPolicyNewForegroundTab, MaybeSetOpener));
m_webView->page()->setDefersLoading(false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698