Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2162423003: Add SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
f(malita), reed2, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_SUPPORT_LEGACY_ACCESSBITMAP Skia guard to temporarily preserve Skia's old behavior The Skia CL https://codereview.chromium.org/2168483003/ (Deprecate SkDevice::accessBitmap method) is removing this entry point from Skia Committed: https://crrev.com/727785695459aeb43fe33099a21ca101955a1f21 Cr-Commit-Position: refs/heads/master@{#406628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
robertphillips
4 years, 5 months ago (2016-07-20 16:06:40 UTC) #4
f(malita)
lgtm
4 years, 5 months ago (2016-07-20 16:47:52 UTC) #7
reed1
looks-woot-to-me
4 years, 5 months ago (2016-07-20 17:06:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162423003/1
4 years, 5 months ago (2016-07-20 18:42:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 18:49:12 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:51:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/727785695459aeb43fe33099a21ca101955a1f21
Cr-Commit-Position: refs/heads/master@{#406628}

Powered by Google App Engine
This is Rietveld 408576698