Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 21624006: ParameterMirror: Implement some missing getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 5fb76c7c6bf92029ba1a117eb97ee0ec31daaa6c..45a424f9890391756f3a65359c49b72302319e15 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -635,7 +635,7 @@ class _LocalFunctionTypeMirrorImpl extends _LocalClassMirrorImpl
static TypeMirror _FunctionTypeMirror_return_type(reflectee)
native "FunctionTypeMirror_return_type";
- static List<ParameterMirror> _FunctionTypeMirror_parameters(reflectee)
+ List<ParameterMirror> _FunctionTypeMirror_parameters(reflectee)
native "FunctionTypeMirror_parameters";
}
@@ -974,7 +974,7 @@ class _LocalMethodMirrorImpl extends _LocalDeclarationMirrorImpl
static dynamic _MethodMirror_return_type(reflectee)
native "MethodMirror_return_type";
- static List<MethodMirror> _MethodMirror_parameters(reflectee)
+ List<ParameterMirror> _MethodMirror_parameters(reflectee)
native "MethodMirror_parameters";
}
@@ -1022,14 +1022,22 @@ class _LocalVariableMirrorImpl extends _LocalDeclarationMirrorImpl
class _LocalParameterMirrorImpl extends _LocalVariableMirrorImpl
implements ParameterMirror {
- _LocalParameterMirrorImpl(this._reflectee,
+ _LocalParameterMirrorImpl(reflectee,
+ String simpleName,
+ DeclarationMirror owner,
this._position,
- this.isOptional)
- : super(null, '<TODO:unnamed>', null, null, false, false);
+ this.isOptional,
+ this.isNamed)
+ : super(reflectee,
+ simpleName,
+ owner,
+ null, // We override the type.
+ false, // isStatic does not apply.
+ false); // TODO(12196): Not yet implemented.
- final _MirrorReference _reflectee;
final int _position;
final bool isOptional;
+ final bool isNamed;
String get defaultValue {
throw new UnimplementedError(

Powered by Google App Engine
This is Rietveld 408576698