Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 21624006: ParameterMirror: Implement some missing getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 7c7331fb53ae502ca2d509235e690ff16e25ca0f..88a89cc5a2f220466eb79773bbcc1d36b80ca401 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -669,7 +669,7 @@ class _LocalFunctionTypeMirrorImpl extends _LocalClassMirrorImpl
static Type _FunctionTypeMirror_return_type(reflectee)
native "FunctionTypeMirror_return_type";
- static List<ParameterMirror> _FunctionTypeMirror_parameters(reflectee)
+ List<ParameterMirror> _FunctionTypeMirror_parameters(reflectee)
native "FunctionTypeMirror_parameters";
}
@@ -1017,7 +1017,7 @@ class _LocalMethodMirrorImpl extends _LocalDeclarationMirrorImpl
static dynamic _MethodMirror_return_type(reflectee)
native "MethodMirror_return_type";
- static List<MethodMirror> _MethodMirror_parameters(reflectee)
+ List<ParameterMirror> _MethodMirror_parameters(reflectee)
native "MethodMirror_parameters";
}
@@ -1065,14 +1065,22 @@ class _LocalVariableMirrorImpl extends _LocalDeclarationMirrorImpl
class _LocalParameterMirrorImpl extends _LocalVariableMirrorImpl
implements ParameterMirror {
- _LocalParameterMirrorImpl(this._reflectee,
+ _LocalParameterMirrorImpl(reflectee,
+ String simpleName,
+ DeclarationMirror owner,
this._position,
- this.isOptional)
- : super(null, '<TODO:unnamed>', null, null, false, false);
+ this.isOptional,
+ this.isNamed)
+ : super(reflectee,
+ simpleName,
+ owner,
+ null, // We override the type.
+ false, // isStatic does not apply.
+ false); // TODO(12196): Not yet implemented.
- final _MirrorReference _reflectee;
final int _position;
final bool isOptional;
+ final bool isNamed;
String get defaultValue {
throw new UnimplementedError(
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698