Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tests/lib/mirrors/stringify.dart

Issue 21624006: ParameterMirror: Implement some missing getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/stringify.dart
diff --git a/tests/lib/mirrors/stringify.dart b/tests/lib/mirrors/stringify.dart
index 0e3b2c0805738da11f5984b10e66fc0103ce90d4..c8893200cd0983f884c252a7d0f21534ed58b931 100644
--- a/tests/lib/mirrors/stringify.dart
+++ b/tests/lib/mirrors/stringify.dart
@@ -66,9 +66,11 @@ stringifyParameter(ParameterMirror parameter) {
writeVariableOn(parameter, buffer);
if (parameter.isOptional) buffer.write(', optional');
if (parameter.isNamed) buffer.write(', named');
- if (parameter.hasDefaultValue) {
- buffer.write(', value = ${stringify(parameter.defaultValue)}');
- }
+ // TODO(6490,12430): Add this check as soon as it's properly implemented in
+ // the VM and dart2js.
ahe 2013/08/13 21:32:55 Remove extra whitespace at beginning of line.
Michael Lippautz (Google) 2013/08/13 21:37:10 Done.
+ // if (parameter.hasDefaultValue) {
+ // buffer.write(', value = ${stringify(parameter.defaultValue)}');
+ // }
// TODO(ahe): Move to writeVariableOn.
buffer.write(', type = ${stringify(parameter.type)}');
return 'Parameter($buffer)';
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698