[SVG] Position set by low priority animation is ignored even though it is active

[SVG] Position set by low priority animation is ignored even though it is active

In accordance with SMIL animation sandwich model for multiple animations acting on the same element:
http://www.w3.org/TR/2005/REC-SMIL2-20051213/animation.html#animationNS-AnimationSandwichModel

Once the higher priority animation is completed, the animValue should be the value set by low priority animation if it is still active.
In our case, the value is wrongly set to the baseValue even though there is still an active low priority animation.
Modified the logic for higher priority animation to not clear the value set by low priority animation in such a case.

R=pdr@chromium.org, schenney@chromium.org, fmalita@chromium.org, dschulze@chromium.org
BUG=267074
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155414

[pavane, 2013-08-01 21:41:01]

Please have a look at this patch

[pdr., 2013-08-01 21:58:51]

https://codereview.chromium.org/21624005/diff/1/Source/core/svg/animation/SVG...
File Source/core/svg/animation/SVGSMILElement.cpp (right):

https://codereview.chromium.org/21624005/diff/1/Source/core/svg/animation/SVG...
Source/core/svg/animation/SVGSMILElement.cpp:1113: endedActiveInterval();
Will this endedActiveInterval() call break dynamic times for the lower-priority
animation?

[pdr., 2013-08-01 22:20:41]

LGTM

On 2013/08/01 21:58:51, pdr wrote:
>
https://codereview.chromium.org/21624005/diff/1/Source/core/svg/animation/SVG...
> File Source/core/svg/animation/SVGSMILElement.cpp (right):
> 
>
https://codereview.chromium.org/21624005/diff/1/Source/core/svg/animation/SVG...
> Source/core/svg/animation/SVGSMILElement.cpp:1113: endedActiveInterval();
> Will this endedActiveInterval() call break dynamic times for the
lower-priority
> animation?

I missed this. endedActiveInterval() only clears the dynamic conditions for the
higher priority animation, not for all animations

[commit-bot: I haz the power, 2013-08-01 23:03:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavan.e@samsung.com/21624005/1

[commit-bot: I haz the power, 2013-08-02 02:35:35]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-08-02 06:13:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavan.e@samsung.com/21624005/1

[commit-bot: I haz the power, 2013-08-02 06:41:37]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-02 06:51:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavan.e@samsung.com/21624005/1

[commit-bot: I haz the power, 2013-08-02 07:26:37]

Change committed as 155414