Remove video-test.js dependency from video-[poster*, replaces*] tests.

Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956
Committed: https://crrev.com/666629d6ddb1a480e474239723f37a135c2ebdc5
Cr-Commit-Position: refs/heads/master@{#406551}

[Srirama, 2016-07-20 10:55:40]

Description was changed from

==========
fix

BUG=
==========

to

==========
Remove video-test.js dependency from video-poster* tests.

BUG=588956
==========

[Srirama, 2016-07-20 10:56:27]

Description was changed from

==========
Remove video-test.js dependency from video-poster* tests.

BUG=588956
==========

to

==========
Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956
==========

[Srirama, 2016-07-20 11:01:13]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-20 11:01:13]

PTAL.

[fs, 2016-07-20 11:14:49]

lgtm

(It's good to get some try bot results for changes like this, with changes to
expectations, so that one can show what the baseline changes will look like. I
assume it's only the DRT output that changes in this case.)

[Srirama, 2016-07-20 11:18:17]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 11:18:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Srirama, 2016-07-20 11:30:59]

On 2016/07/20 11:14:49, fs wrote:
> lgtm
> 
> (It's good to get some try bot results for changes like this, with changes to
> expectations, so that one can show what the baseline changes will look like. I
> assume it's only the DRT output that changes in this case.)

Infact there is a change in *.png files also when i ran locally. The only
difference i can find is that video-test.js is doing "dumpAsText" but adding
that here doesn't generate *.png files. I added some arbitrary text just to see
if it shows a diff in *.png file, but there are no png files in the layout test
results.

[fs, 2016-07-20 11:46:08]

On 2016/07/20 at 11:30:59, srirama.m wrote:
> On 2016/07/20 11:14:49, fs wrote:
> > lgtm
> > 
> > (It's good to get some try bot results for changes like this, with changes
to
> > expectations, so that one can show what the baseline changes will look like.
I
> > assume it's only the DRT output that changes in this case.)
> 
> Infact there is a change in *.png files also when i ran locally. The only
difference i can find is that video-test.js is doing "dumpAsText" but adding
that here doesn't generate *.png files. I added some arbitrary text just to see
if it shows a diff in *.png file, but there are no png files in the layout test
results.

It could be that the png baselines in the tree are stale (not updated w/ changes
to the test/framework). We'll see when the bots are done. Like they are now,
there would be pixel+text results - while it looks like previously there would
only be text (which doesn't appear all that useful for these tests.)

[fs, 2016-07-20 11:51:52]

On 2016/07/20 at 11:46:08, fs wrote:
> On 2016/07/20 at 11:30:59, srirama.m wrote:
> > On 2016/07/20 11:14:49, fs wrote:
> > > lgtm
> > > 
> > > (It's good to get some try bot results for changes like this, with changes
to
> > > expectations, so that one can show what the baseline changes will look
like. I
> > > assume it's only the DRT output that changes in this case.)
> > 
> > Infact there is a change in *.png files also when i ran locally. The only
difference i can find is that video-test.js is doing "dumpAsText" but adding
that here doesn't generate *.png files. I added some arbitrary text just to see
if it shows a diff in *.png file, but there are no png files in the layout test
results.
> 
> It could be that the png baselines in the tree are stale (not updated w/
changes to the test/framework). We'll see when the bots are done. Like they are
now, there would be pixel+text results - while it looks like previously there
would only be text (which doesn't appear all that useful for these tests.)

I checked the output of the mac_chromium_rel_ng bot, and that looked ok (and
quite possibly the png was stale). Please check the new baselines carefully
though when they turn up.

[commit-bot: I haz the power, 2016-07-20 14:06:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 14:06:45]

Dry run: This issue passed the CQ dry run.

[Srirama, 2016-07-20 14:12:24]

On 2016/07/20 11:51:52, fs wrote:
> On 2016/07/20 at 11:46:08, fs wrote:
> > On 2016/07/20 at 11:30:59, srirama.m wrote:
> > > On 2016/07/20 11:14:49, fs wrote:
> > > > lgtm
> > > > 
> > > > (It's good to get some try bot results for changes like this, with
changes
> to
> > > > expectations, so that one can show what the baseline changes will look
> like. I
> > > > assume it's only the DRT output that changes in this case.)
> > > 
> > > Infact there is a change in *.png files also when i ran locally. The only
> difference i can find is that video-test.js is doing "dumpAsText" but adding
> that here doesn't generate *.png files. I added some arbitrary text just to
see
> if it shows a diff in *.png file, but there are no png files in the layout
test
> results.
> > 
> > It could be that the png baselines in the tree are stale (not updated w/
> changes to the test/framework). We'll see when the bots are done. Like they
are
> now, there would be pixel+text results - while it looks like previously there
> would only be text (which doesn't appear all that useful for these tests.)
> 
> I checked the output of the mac_chromium_rel_ng bot, and that looked ok (and
> quite possibly the png was stale). Please check the new baselines carefully
> though when they turn up.

I checked linux and win *actual.png files and linux matches with mac and in
windows the scrollbar is different but the posters are correct.
Can we go ahead and send it to CQ?

[fs, 2016-07-20 14:25:52]

On 2016/07/20 at 14:12:24, srirama.m wrote:
> On 2016/07/20 11:51:52, fs wrote:
> > On 2016/07/20 at 11:46:08, fs wrote:
> > > On 2016/07/20 at 11:30:59, srirama.m wrote:
> > > > On 2016/07/20 11:14:49, fs wrote:
> > > > > lgtm
> > > > > 
> > > > > (It's good to get some try bot results for changes like this, with
changes
> > to
> > > > > expectations, so that one can show what the baseline changes will look
> > like. I
> > > > > assume it's only the DRT output that changes in this case.)
> > > > 
> > > > Infact there is a change in *.png files also when i ran locally. The
only
> > difference i can find is that video-test.js is doing "dumpAsText" but adding
> > that here doesn't generate *.png files. I added some arbitrary text just to
see
> > if it shows a diff in *.png file, but there are no png files in the layout
test
> > results.
> > > 
> > > It could be that the png baselines in the tree are stale (not updated w/
> > changes to the test/framework). We'll see when the bots are done. Like they
are
> > now, there would be pixel+text results - while it looks like previously
there
> > would only be text (which doesn't appear all that useful for these tests.)
> > 
> > I checked the output of the mac_chromium_rel_ng bot, and that looked ok (and
> > quite possibly the png was stale). Please check the new baselines carefully
> > though when they turn up.
> 
> I checked linux and win *actual.png files and linux matches with mac and in
windows the scrollbar is different but the posters are correct.
> Can we go ahead and send it to CQ?

Absolutely!

[Srirama, 2016-07-20 14:29:00]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-07-20 14:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 14:34:49]

Description was changed from

==========
Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956
==========

to

==========
Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-20 14:34:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 14:36:27]

Description was changed from

==========
Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956
==========

to

==========
Remove video-test.js dependency from video-[poster*, replaces*] tests.

BUG=588956

Committed: https://crrev.com/666629d6ddb1a480e474239723f37a135c2ebdc5
Cr-Commit-Position: refs/heads/master@{#406551}
==========

[commit-bot: I haz the power, 2016-07-20 14:36:29]

Patchset 1 (id:??) landed as
https://crrev.com/666629d6ddb1a480e474239723f37a135c2ebdc5
Cr-Commit-Position: refs/heads/master@{#406551}