Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162343002: tryserver.chromium.linux: convert chromium_trybot builders to remote_run (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

tryserver.chromium.linux: convert chromium_trybot builders to remote_run BUG=584079, 593999 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5400c1fd916ea57fd090ee86031f536f6ac09df7

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1024 lines, -1018 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 3 chunks +60 lines, -65 lines 3 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium.py View 1 chunk +1 line, -0 lines 2 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py View 5 chunks +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_linux.py View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json View 9 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN.json View 15 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN__dbg_.json View 15 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Builder.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Linux.json View 11 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder_Trybot.json View 13 chunks +18 lines, -18 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/bot_update_failure.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json View 11 chunks +15 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json View 12 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 15 chunks +19 lines, -19 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json View 15 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json View 15 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json View 20 chunks +26 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_ng.json View 15 chunks +21 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json View 19 chunks +27 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json View 19 chunks +25 lines, -25 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_archive_rel_ng.json View 8 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_rel_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_dbg_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_rel_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clobber_rel_ng.json View 8 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_32_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_ng.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_rel_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg_32_ng.json View 11 chunks +14 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg_ng.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_gn_chromeos_dbg.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_gn_chromeos_rel.json View 9 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json View 12 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json View 13 chunks +17 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_results.json View 22 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/runhooks_failure_ng.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/script_test_with_overridden_compile_targets.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 12 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 12 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 12 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json View 34 chunks +47 lines, -47 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json View 20 chunks +26 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_trigger_failure.json View 18 chunks +24 lines, -24 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot.json View 11 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_webrtc_patch_on_chromium_trybot_compile_failure.json View 15 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-20 10:46:03 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/2162343002/diff/1/masters/master.tryserver.chromium.linux/master.cfg File masters/master.tryserver.chromium.linux/master.cfg (left): https://codereview.chromium.org/2162343002/diff/1/masters/master.tryserver.chromium.linux/master.cfg#oldcode176 masters/master.tryserver.chromium.linux/master.cfg:176: # to keep them fast. what about this comment? ...
4 years, 5 months ago (2016-07-20 10:48:18 UTC) #5
Paweł Hajdan Jr.
https://codereview.chromium.org/2162343002/diff/1/masters/master.tryserver.chromium.linux/master.cfg File masters/master.tryserver.chromium.linux/master.cfg (left): https://codereview.chromium.org/2162343002/diff/1/masters/master.tryserver.chromium.linux/master.cfg#oldcode176 masters/master.tryserver.chromium.linux/master.cfg:176: # to keep them fast. On 2016/07/20 at 10:48:18, ...
4 years, 5 months ago (2016-07-20 10:53:59 UTC) #8
tandrii(chromium)
good thinking! thanks. LGTM! https://codereview.chromium.org/2162343002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium.py File scripts/slave/recipe_modules/chromium_tests/chromium.py (right): https://codereview.chromium.org/2162343002/diff/1/scripts/slave/recipe_modules/chromium_tests/chromium.py#newcode121 scripts/slave/recipe_modules/chromium_tests/chromium.py:121: 'checkout_dir': 'linux_clobber', On 2016/07/20 10:53:59, ...
4 years, 5 months ago (2016-07-20 11:13:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162343002/1
4 years, 5 months ago (2016-07-20 11:14:36 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 11:19:25 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/5400c1fd916ea57fd090...

Powered by Google App Engine
This is Rietveld 408576698