Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2162333002: Fix incorrect parameter to HasSufficientCapacity (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix incorrect parameter to HasSufficientCapacity It takes the number of additional elements, not the total target capacity. Also, avoid right-shifting a negative integer as this is undefined in general BUG=v8:4909 R=verwaest@chromium.org Committed: https://crrev.com/a76d133f769d51ad3e196142c2176f127eb85966 Cr-Commit-Position: refs/heads/master@{#37901}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-20 10:43:20 UTC) #1
Toon Verwaest
lgtm
4 years, 5 months ago (2016-07-20 11:21:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162333002/1
4 years, 5 months ago (2016-07-20 11:22:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162333002/20001
4 years, 5 months ago (2016-07-20 11:25:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 12:13:07 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:16:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a76d133f769d51ad3e196142c2176f127eb85966
Cr-Commit-Position: refs/heads/master@{#37901}

Powered by Google App Engine
This is Rietveld 408576698