Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 216233013: Oilpan: Build fix after r170389 (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, oilpan-reviews, jsbell
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: Build fix after r170389 r170389 broke oilpan's build (Event related.) This CL rights the ship. TBR=haraken@chromium.org,ager@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M Source/core/events/ApplicationCacheErrorEvent.h View 2 chunks +8 lines, -6 lines 0 comments Download
M Source/core/events/ApplicationCacheErrorEvent.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
6 years, 8 months ago (2014-03-29 07:31:29 UTC) #1
haraken
LGTM. Thanks for the fix!
6 years, 8 months ago (2014-03-29 07:32:26 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-03-29 07:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/216233013/1
6 years, 8 months ago (2014-03-29 07:35:37 UTC) #4
commit-bot: I haz the power
Change committed as 170411
6 years, 8 months ago (2014-03-29 07:35:52 UTC) #5
sof
6 years, 8 months ago (2014-03-29 07:41:54 UTC) #6
Message was sent while issue was closed.
On 2014/03/29 07:32:26, haraken wrote:
> LGTM. Thanks for the fix!

Thanks for checking it over right away :)

(Minimal; I intentionally left the RefPtr => RefPtrWillBeRawPtr switch in
ApplicationCacheHost for https://codereview.chromium.org/216523002/ )

Powered by Google App Engine
This is Rietveld 408576698