Issue 216233013: Oilpan: Build fix after r170389

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216233013: Oilpan: Build fix after r170389 (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
haraken, Mads Ager (chromium)

CC:
blink-reviews, oilpan-reviews, jsbell

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: Build fix after r170389 r170389 broke oilpan's build (Event related.) This CL rights the ship. TBR=haraken@chromium.org,ager@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170411

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	Source/core/events/ApplicationCacheErrorEvent.h	View		2 chunks	+8 lines, -6 lines	0 comments	Download
	M	Source/core/events/ApplicationCacheErrorEvent.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/216233013/1

6 years, 8 months ago (2014-03-29 07:35:37 UTC) #4

sof

6 years, 8 months ago (2014-03-29 07:41:54 UTC) #6

Message was sent while issue was closed.

On 2014/03/29 07:32:26, haraken wrote:
> LGTM. Thanks for the fix!

Thanks for checking it over right away :)

(Minimal; I intentionally left the RefPtr => RefPtrWillBeRawPtr switch in
ApplicationCacheHost for https://codereview.chromium.org/216523002/ )

Expand Messages | Collapse Messages