Add whitelist support for grit repack steps.

Add whitelist support for grit repack steps.

-Adds new repack_options variables
-Updates pragma to output numeric_id instead of resource_id
-Updates find_used_resources.py to filter for numeric_id

To use the existing system you need to do following steps:
1. Remove out directory (we need to do a clean build)
2. Append " enable_resource_whitelist_generation=1" to GYP_DEFINES
3. Run gyp
4. Build your target (e.g. chrome_shell_apk) saving output to a file
   (e.g. build.txt)
5. cat build.txt | tools/resources/find_used_resources.py > whitelist.txt
6. Append " repack_options='--whitelist /path/to/whitelist.txt'"
7. Run gyp
8. Build your target again.
9. ???
10. Profit!!!

BUG=338759
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261611

[aurimas (slooooooooow), 2014-03-28 20:58:39]

newt: PTAL!

Aurimas

[newt (away), 2014-03-31 17:45:13]

https://codereview.chromium.org/216233012/diff/1/build/repack_action.gypi
File build/repack_action.gypi (right):

https://codereview.chromium.org/216233012/diff/1/build/repack_action.gypi#new...
build/repack_action.gypi:28: '<@(pak_inputs)'],
nit: ] on separate line

https://codereview.chromium.org/216233012/diff/1/chrome/tools/build/repack_lo...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/216233012/diff/1/chrome/tools/build/repack_lo...
chrome/tools/build/repack_locales.py:193: filter output pak file resource IDs")
nit: use  implicit line joining instead of \ to concatenate python strings (e.g.
help="...used to" "filter...").
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_l...

Also, I wouldn't add extra indentation for the second line of the help
statement. Also, FYI, dest and default aren't technically needed.

https://codereview.chromium.org/216233012/diff/1/tools/resources/find_used_re...
File tools/resources/find_used_resources.py (right):

https://codereview.chromium.org/216233012/diff/1/tools/resources/find_used_re...
tools/resources/find_used_resources.py:21: foo.cc:22:0: warning: ignoring
#pragma 12345  [-Wunknown-pragmas]
I think it would be helpful to change this message to something like:

  warning: ignoring #pragma whitelisted-resource-12345 [-Wunknown-pragmas]

that'll help someone who sees the build output a) be slightly less confused, and
b) grep for the code that causes the warning and discover that it's 100%
intentional.

[aurimas (slooooooooow), 2014-03-31 17:54:21]

https://codereview.chromium.org/216233012/diff/1/build/repack_action.gypi
File build/repack_action.gypi (right):

https://codereview.chromium.org/216233012/diff/1/build/repack_action.gypi#new...
build/repack_action.gypi:28: '<@(pak_inputs)'],
On 2014/03/31 17:45:14, newt wrote:
> nit: ] on separate line

Done.

https://codereview.chromium.org/216233012/diff/1/chrome/tools/build/repack_lo...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/216233012/diff/1/chrome/tools/build/repack_lo...
chrome/tools/build/repack_locales.py:193: filter output pak file resource IDs")
On 2014/03/31 17:45:14, newt wrote:
> nit: use  implicit line joining instead of \ to concatenate python strings
(e.g.
> help="...used to" "filter...").
>
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_l...
> 
> Also, I wouldn't add extra indentation for the second line of the help
> statement. Also, FYI, dest and default aren't technically needed.

Done.

https://codereview.chromium.org/216233012/diff/1/tools/resources/find_used_re...
File tools/resources/find_used_resources.py (right):

https://codereview.chromium.org/216233012/diff/1/tools/resources/find_used_re...
tools/resources/find_used_resources.py:21: foo.cc:22:0: warning: ignoring
#pragma 12345  [-Wunknown-pragmas]
On 2014/03/31 17:45:14, newt wrote:
> I think it would be helpful to change this message to something like:
> 
>   warning: ignoring #pragma whitelisted-resource-12345 [-Wunknown-pragmas]
> 
> that'll help someone who sees the build output a) be slightly less confused,
and
> b) grep for the code that causes the warning and discover that it's 100%
> intentional.

Done.

[newt (away), 2014-03-31 19:55:52]

lgtm

[aurimas (slooooooooow), 2014-03-31 19:57:51]

Hey Nico,

Please take a look at this change.

Thanks,
Aurimas

[Nico, 2014-03-31 21:59:07]

lgtm

[aurimas (slooooooooow), 2014-04-03 18:21:48]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-03 18:21:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/216233012/60001

[commit-bot: I haz the power, 2014-04-03 18:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 18:26:34]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[aurimas (slooooooooow), 2014-04-03 21:09:35]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-03 21:10:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/216233012/60001

[commit-bot: I haz the power, 2014-04-03 21:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 21:17:54]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[aurimas (slooooooooow), 2014-04-03 21:19:05]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-04-03 21:20:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/216233012/60001

[commit-bot: I haz the power, 2014-04-04 00:52:33]

Change committed as 261611