Make media element sources unique to investigate flaky test

Make media element sources unique to investigate flaky test

BUG=355489
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170412

[philipj_slow, 2014-03-28 06:42:39]

I don't know what the chances are that this is actually the problem, if it seems
completely implausible then I should try something else. It sure seems like the
canplay event just isn't fired, so to investigate that I suppose one could
disable everything except the t.done() in those event handlers. Other ideas
appreciated.

[acolwell GONE FROM CHROMIUM, 2014-03-29 00:37:45]

lgtm

https://codereview.chromium.org/216233003/diff/1/LayoutTests/media/activation...
File LayoutTests/media/activation-behavior.html (right):

https://codereview.chromium.org/216233003/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior.html:13: return src + '?' + Math.random();
nit: Would a global var make this unique, but more deterministic?

[philipj_slow, 2014-03-29 06:27:15]

https://codereview.chromium.org/216233003/diff/1/LayoutTests/media/activation...
File LayoutTests/media/activation-behavior.html (right):

https://codereview.chromium.org/216233003/diff/1/LayoutTests/media/activation...
LayoutTests/media/activation-behavior.html:13: return src + '?' + Math.random();
On 2014/03/29 00:37:46, acolwell wrote:
> nit: Would a global var make this unique, but more deterministic?

Yeah, a simple counter should do the trick, the only thing that matters is that
each media element has a unique source.

[philipj_slow, 2014-03-29 07:22:34]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-29 07:22:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/216233003/20001

[commit-bot: I haz the power, 2014-03-29 08:29:06]

Change committed as 170412