Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2162293002: Remove unused base::Thread::thread_handle() getter. (Closed)

Created:
4 years, 5 months ago by gab
Modified:
4 years, 5 months ago
Reviewers:
danakj, hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused base::Thread::thread_handle() getter. Fix only user (dbus/test_server.cc) to use Thread on stack which is automatically joined on destruction (and thus doesn't need the exposed handle it was using to manually join). BUG=629716 Committed: https://crrev.com/8504bffa5efb122e7e5ac960b745a82b79efef39 Cr-Commit-Position: refs/heads/master@{#406831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/threading/thread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M dbus/test_server.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
gab
@dana for base/ @hashimoto for dbus/ Thanks, Gab
4 years, 5 months ago (2016-07-20 02:06:44 UTC) #7
hashimoto
lgtm
4 years, 5 months ago (2016-07-20 02:40:05 UTC) #8
danakj
LGTM
4 years, 5 months ago (2016-07-20 22:02:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162293002/1
4 years, 5 months ago (2016-07-21 12:16:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 13:43:14 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 13:44:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8504bffa5efb122e7e5ac960b745a82b79efef39
Cr-Commit-Position: refs/heads/master@{#406831}

Powered by Google App Engine
This is Rietveld 408576698