Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2162223003: [Docs] Remove mention of the 'blink' fetch recipe, and re-run asciidoc. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Docs] Remove mention of the 'blink' fetch recipe, and re-run asciidoc. That recipe no longer exists, as of https://chromium.googlesource.com/chromium/tools/depot_tools/+/e0cc9e494929d2fd821a3542096f533001e7d67d Referring to it in the tutorial is misleading. It seems that the docs scripts haven't been run in awhile, so there are some unrelated changes as well. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fac10e1c9a6e6cbf0031a9b4a04c3316803607c4

Patch Set 1 #

Patch Set 2 : revert unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M man/html/depot_tools_tutorial.html View 13 chunks +13 lines, -14 lines 0 comments Download
M man/man7/depot_tools_tutorial.7 View 12 chunks +13 lines, -14 lines 0 comments Download
M man/src/depot_tools_tutorial.txt View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jbroman
Someone was confused about why "fetch blink" didn't work; it should probably be removed from ...
4 years, 5 months ago (2016-07-20 17:17:08 UTC) #4
iannucci
On 2016/07/20 17:17:08, jbroman wrote: > Someone was confused about why "fetch blink" didn't work; ...
4 years, 5 months ago (2016-07-20 18:26:54 UTC) #7
jbroman
Reverted every file without depot_tools_tutorial in the filename. There's still some changes (much of it ...
4 years, 5 months ago (2016-07-20 19:34:58 UTC) #10
iannucci
lgtm thanks
4 years, 5 months ago (2016-07-20 19:36:43 UTC) #11
iannucci
On 2016/07/20 19:36:43, iannucci wrote: > lgtm thanks Oh, and the docs should be automatically ...
4 years, 5 months ago (2016-07-20 19:37:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162223003/20001
4 years, 5 months ago (2016-07-20 19:39:14 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:43:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/fac10e1c9a6e6c...

Powered by Google App Engine
This is Rietveld 408576698