Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2162213002: Revert of [Cronet] Use gn desc to find third party licenses on Android. (Closed)

Created:
4 years, 5 months ago by mef
Modified:
4 years, 5 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Use gn desc to find third party licenses on Android. (patchset #3 id:40001 of https://codereview.chromium.org/2150933007/ ) Reason for revert: Broke the builders by not finding the gn. Original issue's description: > [Cronet] Use gn desc to find third party licenses on Android. > > BUG=606859 > > Committed: https://crrev.com/ccb7680f041642d1c9f957c335996bd239e611c4 > Cr-Commit-Position: refs/heads/master@{#406331} TBR=xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606859 Committed: https://crrev.com/61cbb51bc89158030e30b3f22a0c42dc9d67ad60 Cr-Commit-Position: refs/heads/master@{#406398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/tools/cronet_licenses.py View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mef
Created Revert of [Cronet] Use gn desc to find third party licenses on Android.
4 years, 5 months ago (2016-07-19 22:25:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162213002/1
4 years, 5 months ago (2016-07-19 22:26:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 22:27:41 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 22:29:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61cbb51bc89158030e30b3f22a0c42dc9d67ad60
Cr-Commit-Position: refs/heads/master@{#406398}

Powered by Google App Engine
This is Rietveld 408576698