Add logic to GLRenderer to support RenderPassDrawQuad copying.

cc/output/ca_layer_overlay.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_CA_LAYER_OVERLAY_H_
 #define CC_OUTPUT_CA_LAYER_OVERLAY_H_
 
 #include "base/memory/ref_counted.h"
+#include "cc/base/resource_id.h"
 #include "cc/quads/render_pass.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkMatrix44.h"
 #include "ui/gfx/geometry/rect_f.h"
 
 namespace cc {
 
 class DrawQuad;
 class ResourceProvider;
 
@@ skipping 12 matching lines @@
   gfx::RectF clip_rect;
   // The opacity property for the CAayer.
   float opacity = 1;
   // The transform to apply to the CALayer.
   SkMatrix44 transform = SkMatrix44(SkMatrix44::kIdentity_Constructor);
 
  private:
   friend class base::RefCounted<CALayerOverlaySharedState>;
   ~CALayerOverlaySharedState() {}
 };
 

[ccameron, 2016/07/20 05:32:19]

I'd advocate just stuffing the CopyRenderPassDrawQuadToIOSurface method into
cc::DirectRenderer directly.

[erikchen, 2016/07/20 21:48:01]

Done.

+class RenderPassDrawQuadCopier {
+ public:
+  // On success, the resource will be marked as in-use and will not be reused
+  // until the gpu process has marked the resource as no longer in use. The
+  // caller is required to send the IOSurface to the gpu process.
+  virtual bool CopyRenderPassDrawQuadToIOSurface(const RenderPassDrawQuad* quad,
+                                                 ResourceId* resource_id) = 0;
+  // Immediately releases the IOSurface-backed resources for reuse or deletion.
+  virtual void ReleaseIOSurfaces(const std::vector<ResourceId>& resources) = 0;

[ccameron, 2016/07/20 05:32:19]

ReleaseIOSurfaces appears only to be called from within GLRenderer (here and in
https://codereview.chromium.org/2164613003/) -- let's keep it out of the
interface.

[erikchen, 2016/07/20 21:48:01]

Done.

+  // Informs the RenderPassDrawQuadCopier of the number of copied IOSurfaces for
+  // the current frame, which will affect the IOSurface cache size.
+  virtual void UpdateCopyCountForFrame(size_t count) = 0;

[ccameron, 2016/07/20 05:32:19]

This appears only to be called in testing code. Can it go?

[erikchen, 2016/07/20 21:48:01]

Done.

+};
+
 // Holds all information necessary to construct a CALayer from a DrawQuad.
 class CC_EXPORT CALayerOverlay {
  public:
   CALayerOverlay();
   CALayerOverlay(const CALayerOverlay& other);
   ~CALayerOverlay();
 
   // State that is frequently shared between consecutive CALayerOverlays.
   scoped_refptr<CALayerOverlaySharedState> shared_state;
 

[ccameron, 2016/07/20 05:32:19]

I think this would be easier if we had an enum for type that took on values
- SOLID_COLOR
- RESOURCE
- RENDER_PASS
- FRAMEBUFFER (this one doesn't exist yet, but should in the future)

[erikchen, 2016/07/20 21:48:01]

Hm. I'm not sure how much that helps, since the command buffer doesn't handle
polymorphism very well.

   // Texture that corresponds to an IOSurface to set as the content of the
   // CALayer. If this is 0 then the CALayer is a solid color.
   unsigned contents_resource_id = 0;
   // The contents rect property for the CALayer.
   gfx::RectF contents_rect;
   // The bounds for the CALayer in pixels.
   gfx::RectF bounds_rect;
   // The background color property for the CALayer.
   SkColor background_color = SK_ColorTRANSPARENT;
   // The edge anti-aliasing mask property for the CALayer.
   unsigned edge_aa_mask = 0;
   // The minification and magnification filters for the CALayer.
   unsigned filter;
 };
 
 typedef std::vector<CALayerOverlay> CALayerOverlayList;
 
 // Returns true if all quads in the root render pass have been replaced by
 // CALayerOverlays.
 bool ProcessForCALayerOverlays(ResourceProvider* resource_provider,
                                const gfx::RectF& display_rect,
                                const QuadList& quad_list,
                                CALayerOverlayList* ca_layer_overlays);
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_CA_LAYER_OVERLAY_H_