Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162173002: DBC: Misc double instructions (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Misc double instructions - DoubleToSmi - MathUnary - MathMinMax R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/2c6449087d4315879c578111ba4eb891909b4f94

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Make test deopt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -14 lines) Patch
A + runtime/tests/vm/dart/double_to_smi_test.dart View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
M runtime/vm/assembler_dbc_test.cc View 2 chunks +184 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 2 4 chunks +26 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 2 3 chunks +47 lines, -3 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 5 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
4 years, 5 months ago (2016-07-19 20:42:12 UTC) #3
Florian Schneider
Lgtm https://codereview.chromium.org/2162173002/diff/20001/runtime/tests/vm/dart/double_to_smi_test.dart File runtime/tests/vm/dart/double_to_smi_test.dart (right): https://codereview.chromium.org/2162173002/diff/20001/runtime/tests/vm/dart/double_to_smi_test.dart#newcode20 runtime/tests/vm/dart/double_to_smi_test.dart:20: Expect.equals(-100, count); Maybe also add a case where ...
4 years, 5 months ago (2016-07-20 16:22:02 UTC) #4
zra
https://codereview.chromium.org/2162173002/diff/20001/runtime/tests/vm/dart/double_to_smi_test.dart File runtime/tests/vm/dart/double_to_smi_test.dart (right): https://codereview.chromium.org/2162173002/diff/20001/runtime/tests/vm/dart/double_to_smi_test.dart#newcode20 runtime/tests/vm/dart/double_to_smi_test.dart:20: Expect.equals(-100, count); On 2016/07/20 16:22:02, Florian Schneider wrote: > ...
4 years, 5 months ago (2016-07-20 16:46:23 UTC) #5
zra
4 years, 5 months ago (2016-07-20 16:46:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
2c6449087d4315879c578111ba4eb891909b4f94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698