ash/common/system/user/tray_user_separator.cc - Issue 2162153002: Added Ash.SystemMenu.DefaultView.VisibleItems histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/user/tray_user_separator.cc

Issue 2162153002: Added Ash.SystemMenu.DefaultView.VisibleItems histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary includes after self review. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/system/tray/system_tray_unittest.cc ('K') | « ash/common/system/user/tray_user.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | ash/test/test_system_tray_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/user/tray_user_separator.cc

diff --git a/ash/common/system/user/tray_user_separator.cc b/ash/common/system/user/tray_user_separator.cc

index 328f4a649ab0defe56564b008f7cbab8360a5bdd..744e8e435ec6833dafcd5aa91c3f0358e9d0bcb3 100644

--- a/ash/common/system/user/tray_user_separator.cc

+++ b/ash/common/system/user/tray_user_separator.cc

@@ -11,7 +11,7 @@

namespace ash {

TrayUserSeparator::TrayUserSeparator(SystemTray* system_tray)

- : SystemTrayItem(system_tray), separator_shown_(false) {}

+ : SystemTrayItem(system_tray, USER_SEPARATOR), separator_shown_(false) {}

James Cook 2016/07/20 20:13:49 Do we really need the separator count? If not, you

bruthig 2016/07/21 14:34:58 Added UMA_NOT_RECORDED and kept UMA_TEST because I

views::View* TrayUserSeparator::CreateTrayView(LoginStatus status) {

return NULL;