Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: ash/common/system/tray/tray_popup_item_container.cc

Issue 2162153002: Added Ash.SystemMenu.DefaultView.VisibleItems histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the COUNT value from the SystemMenuDefaultViewRows enum. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/system/tray/tray_popup_item_container.h ('k') | ash/common/system/tray_accessibility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/tray_popup_item_container.cc
diff --git a/ash/common/system/tray/tray_popup_item_container.cc b/ash/common/system/tray/tray_popup_item_container.cc
index 3659ea6e6775c050a96376827854b982f82300bc..103788f7fe4c83a68cafafd0de640ca3df2fb8dc 100644
--- a/ash/common/system/tray/tray_popup_item_container.cc
+++ b/ash/common/system/tray/tray_popup_item_container.cc
@@ -13,14 +13,9 @@
namespace ash {
TrayPopupItemContainer::TrayPopupItemContainer(views::View* view,
- bool change_background,
- bool draw_border)
+ bool change_background)
: active_(false), change_background_(change_background) {
set_notify_enter_exit_on_child(true);
- if (draw_border) {
- SetBorder(
- views::Border::CreateSolidSidedBorder(0, 0, 1, 0, kBorderLightColor));
- }
views::BoxLayout* layout =
new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0);
layout->SetDefaultFlex(1);
@@ -35,6 +30,12 @@ TrayPopupItemContainer::TrayPopupItemContainer(views::View* view,
TrayPopupItemContainer::~TrayPopupItemContainer() {}
+void TrayPopupItemContainer::SetDrawBorder(bool draw_border) {
+ SetBorder(draw_border ? views::Border::CreateSolidSidedBorder(
+ 0, 0, 1, 0, kBorderLightColor)
+ : nullptr);
+}
+
void TrayPopupItemContainer::SetActive(bool active) {
if (!change_background_ || active_ == active)
return;
« no previous file with comments | « ash/common/system/tray/tray_popup_item_container.h ('k') | ash/common/system/tray_accessibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698