ash/common/system/tray/system_tray.cc - Issue 2162153002: Added Ash.SystemMenu.DefaultView.VisibleItems histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/tray/system_tray.cc

Issue 2162153002: Added Ash.SystemMenu.DefaultView.VisibleItems histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the COUNT value from the SystemMenuDefaultViewRows enum. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/system/tray/system_tray.cc

diff --git a/ash/common/system/tray/system_tray.cc b/ash/common/system/tray/system_tray.cc

index 73c0ba6a0762e3b6f8983c5b3863161e5147f85c..979e3a197bf51a66dbd25c7795bd57f0adfe2872 100644

--- a/ash/common/system/tray/system_tray.cc

+++ b/ash/common/system/tray/system_tray.cc

@@ -751,6 +751,8 @@ void SystemTray::CloseSystemBubbleAndDeactivateSystemTray() {

void SystemTray::RecordSystemMenuMetrics() {

DCHECK(system_bubble_);

+ system_bubble_->bubble()->RecordVisibleRowMetrics();

TrayBubbleView* bubble_view = system_bubble_->bubble_view();

int num_rows = 0;

for (int i = 0; i < bubble_view->child_count(); i++) {

« no previous file with comments | « ash/common/system/ime/tray_ime_chromeos.cc ('k') | ash/common/system/tray/system_tray_bubble.h » ('j') | no next file with comments »