Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2162143006: Run exo tests in parallel (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run exo tests in parallel BUG=None R=reveman@chromium.org Committed: https://crrev.com/5fbe6a031d7be91fa3f276a726fb05ed4fb31c82 Cr-Commit-Position: refs/heads/master@{#406564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/exo/test/run_all_unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
oshima
It seems to run just fine. any reason not to do so?
4 years, 5 months ago (2016-07-20 14:19:49 UTC) #3
reveman
I think this was initially copied from Ash unit test but if there's no reason ...
4 years, 5 months ago (2016-07-20 14:25:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162143006/1
4 years, 5 months ago (2016-07-20 15:34:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 15:40:25 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5fbe6a031d7be91fa3f276a726fb05ed4fb31c82 Cr-Commit-Position: refs/heads/master@{#406564}
4 years, 5 months ago (2016-07-20 15:41:57 UTC) #11
oshima
4 years, 5 months ago (2016-07-25 18:09:37 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2178913004/ by oshima@chromium.org.

The reason for reverting is: Could be causing flaky-ness. 

BUG=630625.

Powered by Google App Engine
This is Rietveld 408576698