Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2162143005: Turn ZoneList inner_scopes into a linked list (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
Yang, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn ZoneList inner_scopes into a linked list Replace the zonelist with a link from a scope to any of its inner scopes, and a link to any sibling scope. This makes scopes that track inner scopes use roughly the same amount of space as previously scopes without inner scopes would use for the empty zonelist (pointer to the memory + length field, which, granted could be slightly smaller on 64bit). BUG=v8:5209 Committed: https://crrev.com/f04fd635b6914336d5bbf2f4928139c239945387 Cr-Commit-Position: refs/heads/master@{#37941}

Patch Set 1 #

Patch Set 2 : Properly reparent and disinherit #

Patch Set 3 : Even more properly reparent ... :) #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -48 lines) Patch
M src/ast/scopes.h View 1 2 3 4 chunks +20 lines, -10 lines 0 comments Download
M src/ast/scopes.cc View 1 2 3 13 chunks +36 lines, -28 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-20 12:05:15 UTC) #2
Yang
On 2016/07/20 12:05:15, Toon Verwaest wrote: > ptal src/debug lgtm.
4 years, 5 months ago (2016-07-20 12:08:46 UTC) #3
marja
lgtm \o/ This is cool stuff, the efficient version is also cleaner / more elegant, ...
4 years, 5 months ago (2016-07-21 07:03:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162143005/40001
4 years, 5 months ago (2016-07-21 08:51:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/5363) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-21 08:52:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162143005/60001
4 years, 5 months ago (2016-07-21 09:01:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-21 11:01:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162143005/60001
4 years, 5 months ago (2016-07-21 11:07:20 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-21 11:23:40 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 11:26:02 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f04fd635b6914336d5bbf2f4928139c239945387
Cr-Commit-Position: refs/heads/master@{#37941}

Powered by Google App Engine
This is Rietveld 408576698