Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2162133003: [iOS] Refactor iOS bots definitions. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Refactor iOS bots definitions. Refactor ios-{device,simulator}{,-gn}.json files so that the difference between gyp and gn bot is limited to the "comment" and "mb_type" fields. Sort "gn_args" values so in the same order as the corresponding value in "GYP_DEFINES" (this make it easier to check that both gyp and gn are using the same settings). Convert ios-simulator-gn.json to build a fat binary and run the tests on both a 32-bit and a 64-bit device as ios-simulator.json is doing. BUG=621708 Committed: https://crrev.com/577c4f878e49796e3bcf397c9e97805829c3fb4b Cr-Commit-Position: refs/heads/master@{#406869}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix gyp bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -12 lines) Patch
M ios/build/bots/chromium.mac/ios-device.json View 1 2 chunks +12 lines, -1 line 0 comments Download
M ios/build/bots/chromium.mac/ios-device-gn.json View 2 chunks +8 lines, -4 lines 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator.json View 1 2 chunks +13 lines, -1 line 0 comments Download
M ios/build/bots/chromium.mac/ios-simulator-gn.json View 3 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-20 13:39:34 UTC) #4
Dirk Pranke
lgtm https://codereview.chromium.org/2162133003/diff/1/ios/build/bots/chromium.mac/ios-device.json File ios/build/bots/chromium.mac/ios-device.json (right): https://codereview.chromium.org/2162133003/diff/1/ios/build/bots/chromium.mac/ios-device.json#newcode26 ios/build/bots/chromium.mac/ios-device.json:26: "target_cpu=\"arm\"" I think normally smut@ prefers to have ...
4 years, 5 months ago (2016-07-20 16:19:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 16:21:51 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 16:23:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/577c4f878e49796e3bcf397c9e97805829c3fb4b
Cr-Commit-Position: refs/heads/master@{#406869}

Powered by Google App Engine
This is Rietveld 408576698