Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: runtime/vm/isolate.cc

Issue 2162113002: Revert "Fix use-after-free in isolate reload." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 0b8b5bbf0c4bd1e93527e4d91f9baf16ecf99222..c20def45467837153a63515762f8a6c5f22139bb 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1095,8 +1095,6 @@ void Isolate::ReloadSources(bool test_mode) {
has_attempted_reload_ = true;
reload_context_ = new IsolateReloadContext(this, test_mode);
reload_context_->StartReload();
- delete reload_context_;
- reload_context_ = NULL;
}
#endif // !PRODUCT
@@ -1117,6 +1115,8 @@ void Isolate::DoneFinalizing() {
if (!reload_context_->has_error()) {
reload_context_->ReportSuccess();
}
+ delete reload_context_;
+ reload_context_ = NULL;
}
)
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698