Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 2162083005: Use surface copy requests for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: piman comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 072cfad68e36d00b6e65ff177fd0e019b79e9e39..2ad891e885dd4808e92d9c1806846a6546c46815 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -895,7 +895,7 @@ bool RenderWidgetCompositor::CompositeIsSynchronous() const {
void RenderWidgetCompositor::layoutAndPaintAsync(
blink::WebLayoutAndPaintAsyncCallback* callback) {
- DCHECK(!temporary_copy_output_request_ && !layout_and_paint_async_callback_);
+ DCHECK(!layout_and_paint_async_callback_);
layout_and_paint_async_callback_ = callback;
if (CompositeIsSynchronous()) {
@@ -922,10 +922,21 @@ void RenderWidgetCompositor::InvokeLayoutAndPaintCallback() {
void RenderWidgetCompositor::compositeAndReadbackAsync(
blink::WebCompositeAndReadbackAsyncCallback* callback) {
- DCHECK(!temporary_copy_output_request_ && !layout_and_paint_async_callback_);
- temporary_copy_output_request_ =
- cc::CopyOutputRequest::CreateBitmapRequest(
- base::Bind(&CompositeAndReadbackAsyncCallback, callback));
+ DCHECK(!layout_and_paint_async_callback_);
+ scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner =
+ layer_tree_host_->task_runner_provider()->MainThreadTaskRunner();
+ std::unique_ptr<cc::CopyOutputRequest> request =
+ cc::CopyOutputRequest::CreateBitmapRequest(base::Bind(
+ [](blink::WebCompositeAndReadbackAsyncCallback* callback,
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ std::unique_ptr<cc::CopyOutputResult> result) {
+ task_runner->PostTask(FROM_HERE,
+ base::Bind(&CompositeAndReadbackAsyncCallback,
+ callback, base::Passed(&result)));
+ },
+ callback, base::Passed(&main_thread_task_runner)));
+ layer_tree_host_->QueueSwapPromise(
+ delegate_->RequestCopyOfOutputForLayoutTest(std::move(request)));
// Force a commit to happen. The temporary copy output request will
// be installed after layout which will happen as a part of the commit, for
@@ -1014,17 +1025,6 @@ void RenderWidgetCompositor::BeginMainFrameNotExpectedSoon() {
void RenderWidgetCompositor::UpdateLayerTreeHost() {
delegate_->UpdateVisualState();
- if (temporary_copy_output_request_) {
- // For WebViewImpl, this will always have a root layer. For other widgets,
- // the widget may be closed before servicing this request, so ignore it.
- if (cc::Layer* root_layer = layer_tree_host_->root_layer()) {
- root_layer->RequestCopyOfOutput(
- std::move(temporary_copy_output_request_));
- } else {
- temporary_copy_output_request_->SendEmptyResult();
- temporary_copy_output_request_ = nullptr;
- }
- }
}
void RenderWidgetCompositor::ApplyViewportDeltas(
@@ -1081,7 +1081,6 @@ void RenderWidgetCompositor::WillCommit() {
}
void RenderWidgetCompositor::DidCommit() {
- DCHECK(!temporary_copy_output_request_);
delegate_->DidCommitCompositorFrame();
compositor_deps_->GetRendererScheduler()->DidCommitFrameToCompositor();
}
« no previous file with comments | « content/renderer/gpu/render_widget_compositor.h ('k') | content/renderer/gpu/render_widget_compositor_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698